Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce keep alive threshold #1501

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

pauldambra
Copy link
Member

@pauldambra pauldambra commented Oct 28, 2024

follow-up to #1416

I still sometimes see TypeError: Failed to fetch

we check if the request is less than 64kb, but maybe we then add overhead and so fetch rejects it

let's reduce the threshold so that we can't possibly trigger this error for fetch

Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Oct 28, 2024 3:19pm

@pauldambra pauldambra added the bump patch Bump patch version when this PR gets merged label Oct 28, 2024
@pauldambra pauldambra requested a review from a team October 28, 2024 15:18
Copy link

Size Change: +20 B (0%)

Total Size: 2.94 MB

Filename Size Change
dist/array.full.es5.js 249 kB +2 B (0%)
dist/array.full.js 335 kB +2 B (0%)
dist/array.full.no-external.js 334 kB +2 B (0%)
dist/array.js 166 kB +2 B (0%)
dist/array.no-external.js 165 kB +2 B (0%)
dist/main.js 167 kB +2 B (0%)
dist/module.full.js 335 kB +2 B (0%)
dist/module.full.no-external.js 334 kB +2 B (0%)
dist/module.js 166 kB +2 B (0%)
dist/module.no-external.js 165 kB +2 B (0%)
ℹ️ View Unchanged
Filename Size
dist/all-external-dependencies.js 182 kB
dist/exception-autocapture.js 8.77 kB
dist/external-scripts-loader.js 2.19 kB
dist/recorder-v2.js 102 kB
dist/recorder.js 103 kB
dist/surveys-preview.js 56.7 kB
dist/surveys.js 62.1 kB
dist/tracing-headers.js 1.33 kB
dist/web-vitals.js 10.3 kB

compressed-size-action

@pauldambra pauldambra merged commit 2af6c36 into main Oct 28, 2024
18 checks passed
@pauldambra pauldambra deleted the fix/reduce-keep-alive-threshold branch October 28, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants